770123 - Multiple access keys used in preferences dialog for pl locale

Status: RESOLVED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshots

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/23e194f1171aa4baf774928b262eb02f

Details:

 accessKey: "p" found in: button[label=Pomoc], label[control=defaultFontType][accesskey=P]
accessKey: "n" found in: radio[label=Instaluj aktualizacje automatycznie (zalecane: większe bezpieczeństwo)], radio[label=Nie sprawdzaj dostępności aktualizacji (niezalecane: zagrożenie bezpieczeństwa)]
accessKey: "s" found in: radio[label=Sprawdzaj dostępność aktualizacji, ale wymagaj potwierdzenia ich instalacji], checkbox#enableSearchUpdate

Comment 1

[Stefan Plewako [:stef]]

http://hg.mozilla.org/l10n-central/pl/rev/e8a092e1e5f3

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Stefan. Would you mind to also make this change for Aurora? Our l10n tests are getting run on this branch only. So as of now I cannot check if all is fine now. Thanks.

Comment 3

[Stefan Plewako [:stef]]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Would you mind to also make this change for Aurora? Our l10n
> tests are getting run on this branch only.

No problem, I didn't know that,
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/fadd7e632a4a

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Stefan. So as our tests have been shown there is still an issue on OS X and Linux while all is fine on Windows. Please see the following report:

http://mozmill-daily.blargon7.com/#/l10n/report/ec449c026814fd64783d738c02ae86ae

Issue:
accessKey: "f" found in: label#historyModeLabel, checkbox#rememberForms

Comment 5

[Stefan Plewako [:stef]]

Fixed,
http://hg.mozilla.org/l10n-central/pl/rev/9749a1aec05d
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/fadd7e632a4a

(In reply to Henrik Skupin (:whimboo) from comment #4)
> So as our tests have been shown there is still an issue on OS
> X and Linux while all is fine on Windows. Please see the following report:

It should fail on win too btw…

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Stefan, the last fix hasn't landed on aurora yet. The last landing is from Oct. 15th:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/

I assume something went wrong with the latest push? Can you please check that? Until then I would propose we leave the bug open until we can see the results here: http://mozmill-daily.blargon7.com/#/l10n

Comment 7

[Stefan Plewako [:stef]]

My bad, wrong import command,
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/2400d786673f

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All fine now. Thanks for the follow-up, Stefan! I think we can close it now.