Closed Bug 770133 Opened 12 years ago Closed 12 years ago

duplicated DOM IDs dummycontenttoolbox and dummycontenttoolbar in specialTabs.xul

Categories

(Thunderbird :: Toolbars and Tabs, defect)

15 Branch
x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 16.0

People

(Reporter: teramako, Assigned: teramako)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901

Steps to reproduce:

in specialTabs.xul, same DOM IDs are exist.

http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#21
http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#36

- dummycontenttoolbox
- dummycontenttoolbar

And when open a tab as contentTab or chromeTab type, duplicated element's ids are created with cloneNode.




Expected results:

To be fixed,
 1. )change to dummychrometoolbox and dummychrometoolbar from dummycontenttoolbox and dummycontenttoolbar in chromeTab id's element.

 2.) change ids after cloneNode on "openTab" method each of chromeTab and contentTab.
Attached patch patch 1Splinter Review
Status: UNCONFIRMED → ASSIGNED
Component: General → Toolbars and Tabs
Ever confirmed: true
QA Contact: general → toolbars-tabs
Comment on attachment 638322 [details] [diff] [review]
patch 1

Thank you very much for the patch. In order to get things in, you'll need to set the review request to someone. Just doing this for you now.
Attachment #638322 - Flags: review?(mconley)
Assignee: nobody → teramako
Comment on attachment 638322 [details] [diff] [review]
patch 1

Review of attachment 638322 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome - thanks for the patch!
Attachment #638322 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/6446a293fb93
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: