770287 - IDBIndex.h:162:25: warning: ‘...mActorParent’ will be initialized after... ‘...mKeyPath’ [-Wreorder]

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: fix

In file included from ../../../mozilla/dom/indexedDB/IDBIndex.cpp:9:0:
../../../mozilla/dom/indexedDB/IDBIndex.h: In constructor ‘mozilla::dom::indexedDB::IDBIndex::IDBIndex()’:
../../../mozilla/dom/indexedDB/IDBIndex.h:162:25: warning: ‘mozilla::dom::indexedDB::IDBIndex::mActorParent’ will be initialized after [-Wreorder]
../../../mozilla/dom/indexedDB/IDBIndex.h:158:11: warning:   ‘mozilla::dom::indexedDB::KeyPath mozilla::dom::indexedDB::IDBIndex::mKeyPath’ [-Wreorder]
../../../mozilla/dom/indexedDB/IDBIndex.cpp:395:1: warning:   when initialized here [-Wreorder]

This is from this block:
395 IDBIndex::IDBIndex()
396 : mId(LL_MININT),
397   mActorChild(nsnull),
398   mActorParent(nsnull),
399   mKeyPath(0),

and mKeyPath is declared before mActorChild in the class, so it should be listed before it in the init list.  Attached patch makes this change.

Comment 1

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ea07a17e25c

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ea07a17e25c