770297 - Call to isLaunchable in getSelf/getInstalled/getAll/getNotInstalled needs to be the app origin, not the install origin

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Jason Smith [:jsmith]]

Steps:

1. Go to marketplace.mozilla.org
2. Install a free web application
3. Uninstall the free web application
4. Go to app page for the app in step #2

Expected:

The app install button should be showed as "install"

Actual:

The app install button is still showed as "installed." Under the hood, they are using getInstalled() to determine this.

Comment 1

[Jason Smith [:jsmith]]

Looks like this generally applies to getAll() and getInstalled()

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Pushed patch to try, https://tbpl.mozilla.org/?tree=Try&rev=b7eafe9208af
Builds to appear at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b7eafe9208af

Comment 3

[Jason Smith [:jsmith]]

Working with Felipe, we've figured out the root cause. Looks like the calls to isLaunchable in getSelf/getInstalled/getAll/getNotInstalled is using the install origin, not the app origin. That explains why there's a lot of problems being seen.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Huh I was using the wrong origin to check if an app was installed, which had the amusing effect of considering if an app was installed or not based on if you had the Marketplace app itself installed

Comment 8

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/8155cc5972d6

Comment 9

[Jason Smith [:jsmith]]

Did a good amount of testing with the try build on Windows - it works! Did tests such as:

- Installing and uninstalling apps on marketplace
- Viewing apps on the myapps dashboard
- Installing apps with and without appcache support
- Testing apps natively vs. acquired

Comment 10

[Marco Castelluccio [:marco]]

Just tested with Linux and it's working.

Comment 11

[Jason Smith [:jsmith]]

Verified on Nightly for Windows 7, Windows XP, OS X 10.7, and Ubuntu 12.