770755 - Throw a warning when app name is too long for Gaia

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, enhancement, P5)

Description

[Christopher Van Wiemeersch [:cvan]]

We limit app names to 128 characters on Marketplace. And developers specify long names in their manifests so when users go to install the app and launch it from their B2G phones, the name gets truncated.

If the "name" is longer than 9 characters (I think that's about the max), throw a warning telling them it will be truncated when natively installed.

Comment 1

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/amo-validator/pull/167/files

Comment 2

[Jason Smith [:jsmith]]

Isn't this fixed? I saw this working on the marketplace prod just now doing a test.

Comment 3

[Matt Basta [:basta]]

Ah yes. Whoever closed the pull request didn't close the bug.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

See https://github.com/mozilla/amo-validator/pull/167/files#r1199160

Comment 5

[Matt Basta [:basta]]

Updated

Comment 6

[Frederik Braun [:freddy]]

The current checks, just look at the name attribute, not at the localized name...

(Meta: Should I look at the app-validator or at the amo-validator repo?)

Comment 7

[Matt Basta [:basta]]

Here's the code that performs the check:

https://github.com/mozilla/app-validator/blob/master/appvalidator/webapp.py#L38

Comment 8

[Frederik Braun [:freddy]]

So this code is just looking at name but not at the localized names.
I wonder if it should iterate through all given in the locales dict and check the names in there too.

Comment 9

[Matt Basta [:basta]]

I've filed bug 870393 to fix that issue.