770850 - DOH! DefnOrHeader should be called DefinitionList

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

ParseMaps.h is a big improvement over the prior situation, but parts of its implementation are pretty baffling. In particular, there's a nicer way to express what DefnOrHeader is doing.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Jason Orendorff [:jorendorff]]

Handy cheat sheet:

DefnOrHeader --> DefinitionList
AtomDeclNode --> DefinitionList::Node
MultiDeclRange --> DefinitionList::Range
doh.isHeader() --> dlist.isMultiple()
AtomDOHMap --> AtomDefnListMap

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79672ac5f11b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79672ac5f11b