770928 - Unable to invoke the text-interaction bar (ActionMode) on a URL in Android 4.1

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Long-tap and hold on the current URL. 

ER: ICS/Jellybean text-interaction bar - (context-menu, 2.2/2.3)
AR: Nothing

Bring back the text-interaction bar.

--
Samsung Galaxy Nexus (Android 4.1)
Nightly (07/04)

Comment 1

[Aaron Train [:aaronmt]]

My mistake, looks like we have a 4.1 issue here.

Comment 2

[Aaron Train [:aaronmt]]

Sriram, do we need startActionMode?

Comment 3

[Aaron Train [:aaronmt]]

This will be a pain-point for a functional loss and negative review for JB users.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Actual STR:
1. Tap on the URL bar
2. Long tap on the "editable" url.

Comment 5

[Sriram Ramasubramanian [:sriram]]

We currently don't use ActionBar in AwesomeBar. It's hidden in AwesomeBar.
In ICS:
  When we long press, android brings up the text-interaction bar -- even when we make the ActionBar visibility to be "gone".

In JB:
  When we long press, android doesn't bring up the text-interaction bar -- as the visibility of the ActionBar is "gone".

Now, we can override the long press on the editable text to show the action-bar.
But, we won't know when the user is done with the options android gives, as we don't own the ActionMode.Callback to monitor the change of ActionBar. So, we cannot close it.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

tracking for 15 just because we'll want to make an explicit call about uplifting when we have a patch to evaluate

Comment 7

[Aaron Train [:aaronmt]]

Nexus S users just got 4.1.1 [1], just got it on my phone. Confirming same issue on my Nexus S.

[1] http://www.androidcentral.com/android-411-jelly-bean-ota-now-appearing-some-nexus-s-variations

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Carrying forward tracking from bug 760160 so we can keep this on our radar.

Comment 10

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch finally fixes it.
Basic problems:
 JB is strict with ActionBar! If we specify the visibility as "gone", it won't show text interaction.
 We don't own the ActionMode when it is shown, and hence we cannot hide it when text-editing is done.

Solution:
 On long press, show the action-bar. Android takes care of the action-mode there.
 When we know the text has changed -- possibly by cut/paste,
 or when the selection has changed -- by dismissing the selected text -- possibly by copy/done/tapping on EditText
 hide the actionbar.

Comment 11

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This fixes one other bug.

Comment 12

[Matt Brubeck (:mbrubeck)]

Comment on attachment 646375 [details] [diff] [review]
Patch

Review of attachment 646375 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AwesomeBar.java
@@ +217,5 @@
> +            @Override
> +            public boolean onLongClick(View v) {
> +                if (Build.VERSION.SDK_INT >= 11 && ((CustomEditText) v).getText().length() > 0) {
> +                    getActionBar().show();
> +                    return false;

Should we "return true" here?

::: mobile/android/base/CustomEditText.java
@@ +26,5 @@
>      public void setOnKeyPreImeListener(OnKeyPreImeListener listener) {
>          mOnKeyPreImeListener = listener;
>      }
>  
> +    OnSelectionChangedListener mOnSelectionChangedListener;

Minor nit: Please move all the new code below the onKeyPreIme() method (so all the onKeyPreImeListener code remains together).

Comment 13

[Aaron Train [:aaronmt]]

QA Note:

Look for no functional loss on all other supported Android versions.

Comment 14

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d45e4a0ec5aa

There are 11+ checks everywhere. So it won't affect.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d45e4a0ec5aa

Comment 16

[Aaron Train [:aaronmt]]

This broke Honeycomb in bug 778438.

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

please nominate for uplift if this is low-risk enough to consider. i've also tracked bug 778438 so we can ensure we take the honeycomb breakage fix at the same time.

Comment 18

[Aaron Train [:aaronmt]]

Uplift! Go-go-go

Comment 19

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 646386 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Users cannot cut-copy-paste on awesomescreen.
Testing completed (on m-c, etc.): Landed in m-c on 07/27
Risk to taking this patch (and alternatives if risky): Bug 760160.
String or UUID changes made by this patch: None.

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 646386 [details] [diff] [review]
Patch

Not sure why the possible fallout from this bug is linking to a bug that is resolved as duplicate of _this_ bug, but I assume that means any fallout from this patch will be tracking in this bug.

Comment 21

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/35eecb9cc1aa

Comment 22

[Sriram Ramasubramanian [:sriram]]

Pushed to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/5b96d31cd936

Comment 23

[Cristian Nicolae (:xti)]

Indeed, it's fixed on all branches.

--
Device: Galaxy Note
OS: Android 4.1.1

Comment 24

[Martijn Wargers (dead)]

I need 3 long taps before I finally get the text-interaction bar to appear for the url bar. That seems very excessive, so I filed bug 797565 for it.