770999 - Convert reference(), value(), raw() on handles and Root<> to get()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

There are a number of ways to get the value out of a rooted thing explicitly, but they differ depending on whether you have a Handle<> or a Root<>. Also, HeapPtr<> has its own method called get() to do pretty much the same thing. I like get() best because it's short, so I converted the other ones to it. I'm open to changing the name, but I think it's useful for them all to be the same.

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 639175 [details] [diff] [review]
patch

Review of attachment 639175 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Root.h
@@ +212,5 @@
>      T operator ->() const { return ptr; }
>      T * address() { return &ptr; }
>      const T * address() const { return &ptr; }
> +    T & get() { return ptr; }
> +    T get() const { return ptr; }

Can the const method here just be removed?  It looks weird to have overloads that return either a T or a T&, and Rooted should never be const anyways.  (I see a CrossCompartmentKey constructor that does this, but that signature is broken)

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/mozilla-central/rev/2ecd5bbb5289