Closed Bug 771377 Opened 12 years ago Closed 12 years ago

Marketplace theme/persona previews do not work

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cvan, Assigned: kngo)

References

()

Details

(Keywords: regression)

Steps to reproduce:
1. Load a theme page: https://marketplace-dev.allizom.org/en-US/theme/somewhere-beneath-the-golde/
2. Click on a preview image.
3. Nothing happens. There used to be "reset" text overlaying the preview, and the theme would be previewed in the browser.

Probably caused by https://github.com/mozilla/zamboni/commit/7512a5cc
Assignee: nobody → ngoke
I don't think that patch caused the regression, and doesn't touch JS. I don't ever remember it working locally; the reset overlay appears but doesn't do anything. Installing works on -dev though.

I looked further and all the proper events are fired off to the browser (PreviewBrowserTheme, ResetBrowserThemePreview, InstallBrowserTheme)...
https://github.com/mozilla/zamboni/commit/d1209e359bf1f6043063c966588207a57b1a62a7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified as fixed. Even if the designs were changed , the main issue from this bug is fixed : http://screencast.com/t/5olkCDd5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.