Closed
Bug 771489
Opened 12 years ago
Closed 12 years ago
use standard threadsafe refcounting in host resolver
Categories
(Core :: Networking: DNS, defect)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 2 obsolete files)
|
4.94 KB,
patch
|
Details | Diff | Splinter Review |
We should use standard threadsafe refcounting in the host resolver, not a custom scheme.
Attachment #639635 -
Flags: review?(sworkman)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 639635 [details] [diff] [review] fix v1.0 Looks good to me. Thanks Josh.
Attachment #639635 -
Flags: review?(sworkman) → review+
There was some funny business with how the refcount was initialized for host records. This should fix it.
Attachment #639635 -
Attachment is obsolete: true
The refcounting was fine, nothing was actually leaking, but refcount reporting was bad so the tests thought something was leaking. This is exactly why we need to get on a standardized addref/release scheme.
Attachment #639958 -
Attachment is obsolete: true
pushed to mozilla-inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/7578fa8c76f7
|
||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7578fa8c76f7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•