771498 - FileHandle: getFile() should return a DOMRequest (instead of a FileRequest)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Jan Varga [:janv]]

Attachment: fix

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 639938 [details] [diff] [review]
fix

Review of attachment 639938 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 639938 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
This is a bug in a new feature

User impact if declined:
There's a risk that developers will misunderstand how this new API is supposed to be used. This has already happened which is how we found this bug. Such misunderstanding will lead to a slower website and probably in the future we'll be foreced to break this behavior, causing websites to break.

Testing completed (on m-c, etc.):
Patch contains mochitest and should land very soon on m-c.

Risk to taking this patch (and alternatives if risky): 
There's very little risk. The patch logic is very simple, and it strictly speaking just removes functionality from websites.

String or UUID changes made by this patch:
Only changes the UUID of APIs which are new for FF15

Comment 4

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5549659290f7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5549659290f7

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 639938 [details] [diff] [review]
fix

[Triage Comment]
New APIs in FF15, so no problem with approving this change. Can you make sure to block the original feature bug on this one? Thanks.

Comment 7

[Jan Varga [:janv]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/de20a11fba94