771595 - Gonk widget fails to initialize the framebuffer if GL context creation fails

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Marshall Culpepper [:marshall_law]]

In AOSP qemu, the fallback software rendering EGL lib doesn't support GLES 2.0, which means the GL context isn't created by GLContextProviderEGL.

Currently, accelerated rendering and the framebuffer are only initialized before the attempt to create the GL context. 

The fix is to wait until _after_ attempting to create the GL context before checking whether the framebuffer needs to be initialized, and then appropriately set the |mUseAcceleratedRendering| flag..

(Note: move this to Widget: Gonk component once it's created in Bug 771591)

Comment 1

[Marshall Culpepper [:marshall_law]]

The 2nd half of the emulator black screen issue on B2G github:
https://github.com/mozilla-b2g/B2G/issues/51

Comment 2

[Marshall Culpepper [:marshall_law]]

Attachment: Framebuffer fallback on !sGLContext

Comment 3

[Marshall Culpepper [:marshall_law]]

Attachment: Framebuffer fallback on !sGLContext - v2

Comment 4

[Marshall Culpepper [:marshall_law]]

Attachment: Framebuffer fallback on !sGLContext - v2 (rebased)

Rebased

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71be75e10f5f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71be75e10f5f