771715 - Implement Notifications

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: Social Integration, defect, P2)

Description

[Ben (:bensternthal)]

We will need to implement fb notifications based on criteria. Working document is here but not final. Once final I will note in the bug.

https://etherpad.mozilla.org/Affiliates-FB-NotificationTypes

Comment 1

[Ben (:bensternthal)]

Note the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=775585

We will add Bob created an ad with Affiliates Facebook", and maybe even "Bob created a paid ad with Affiliates Facebook"

For in app notifications, these are noted in a future features etherpad

https://romana.etherpad.mozilla.org/Affiliates-FB-FutureWishList

Comment 2

[Osmose [:osmose, :mkelly]]

These got punted to the next release.

Comment 3

[Osmose [:osmose, :mkelly]]

chelsea: The last discussion that happened around this feature turned to putting notifications in the app rather than using any Facebook feature. Given that, we have two obvious options for handling this:

1. Use the existing notification boxes to display these messages when a user first logs in. See http://cl.ly/image/1n0Z3X1A2C2F to see what I'm talking about.

2. Add some sort've notification center, perhaps a sidebar module? This would need a bit of thought/design around how it looks and functions.

Which option do you prefer?

Comment 4

[Chelsea Novak [:chelsea]]

I think option one makes the most sense.

Comment 5

[Osmose [:osmose, :mkelly]]

Cool. Once we have a final list of notifications and their text we can start implementing this.

Comment 6

[Chelsea Novak [:chelsea]]

Copy options added to the etherpad in comment 1

Comment 7

[[github robot]]

Commits pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/88852675589b21de3e9f457de6146cfd027a5cf1
Bug 771715: Add AppNotifications to tell users about special events.

Adds a new model, AppNotification, that is shown to the user once when
they login, and then is deleted. They're similar to django messages, but
are persistent.

Adds a hook in the click task to create notifications about click count
milestones, as well as a pre_save signal to FacebookBannerInstances that
tells users when their banner has been approved as an ad.

Also adds the ability to use fb_redirect for redirects within the app.
This solves an issue where context processors and middleware that
require an active login session wouldn't run on the first page because
the user auths during that request after they have run. Now, the first
page uses the JavaScript redirect in fb_redirect to force a new request
with the new authed session.

https://github.com/mozilla/affiliates/commit/640f96d22a421b29598f217b838a8eb5fb6ec03f
Fix Bug 771715: Add tests.

Adds jingo to vendor-local to retrieve an up-to-date version that 
supports rendering templates properly for one of the new tests.

Comment 8

[Osmose [:osmose, :mkelly]]

STV: Verify that you get notifications when you log into the Facebook app after a banner you've created gets the following amount of clicks (protip: To get lots of clicks quickly, Cmd+Click the banner after sharing on your wall a bunch of times):

- 10 clicks
  Way to go! You've had 10 clicks on your Firefox banner

- 25 clicks
  Amazing! You've had 25 on your Firefox banner. Thanks for spreading the word. 

- 50 clicks
  Wow! Your banner has 50 clicks! It's ready to grow up and become a Firefox ad.

Notifications look like a box with a checkmark near the top of the main page shown after you log into the Facebook app.

Also, verify that you receive a notification after your submitted banner has been approved via the admin interface. I can approve a banner for you during testing.

- Banner is now an ad
  Congratulations! Your Firefox banner has now become a Facebook ad!

Comment 9

[Matt Brandt [:mbrandt]]

QA verified on stage - this looks good.
- The ability to link an existing affiliates account to FB works
- The ability to create banners works as expected
- The ability to use existing banners works as well as delete banners works as expected
- Messages associated with different click counts works as expected
- Leaderboard counts on FB and the mothership increment as clicks are made
- Statistics displays increment as expected