771894 - [mozillians] Province/State should not be required for some regions

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Tomer Cohen :tomer]

In some regions in the world it doesn't make sense to specify Province/State, and people in such locations never fill the Province/State fields. 

In mozillians.org this field is required, and I find it useless to set it to a dummy string. Instead, I'd suggest having an option to keep it blank or make it required only to specific countries (such as the US, for example).

Comment 1

[Jonathan Protzenko [:protz]]

Yes, this feels like one more case of US-centrism, and I think we can avoid uselessly offending people by not requiring the state :).

Comment 2

[Rimas Kudelis [use needinfo to ping]]

I was going to file this bug too, but noticed that it's already here. Please fix this annoyance. That field should indeed be optional.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

Currently 'Province/State' is required only if you specify a city. If you don't specify a city you don't need to fill in 'Province/State' Do you think that we should make field optional in all occasions?

btw I believe 'Region' is more appropriate to 'Province/State'

Comment 4

[Rimas Kudelis [use needinfo to ping]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #3)
> Currently 'Province/State' is required only if you specify a city. If you
> don't specify a city you don't need to fill in 'Province/State' Do you think
> that we should make field optional in all occasions?

Yes, please. In many countries regions aren't signified as much as they are in US. E.g. in Lithuania, the region is usually skipped unless you live in a small town or a village, in which case the region might be needed as a clarification.

> btw I believe 'Region' is more appropriate to 'Province/State'

http://youtu.be/ussCHoQttyQ ;)

Comment 5

[John Kim [snoozes]]

Hello.

I submitted a pull request on the following change:
  Deleted the requirement for the Province/State in apps/phonebook/forms.py

Comment 6

[John Kim [snoozes]]

I resubmitted the pull request with the message change.  Sorry for the inconvenience.

Comment 7

[John Kim [snoozes]]

I submitted a new commit where we added a new test case in phonebook/test/test_edit_profile.py and made a small change in phonebook/forms.py.
Hopefully forms.py works properly this time around.

Comment 8

[John Kim [snoozes]]

Hello.
I attempted at squashing all my commits but I believe that I did it wrong.  Could someone help me on how to fix this or how to squash properly?

Comment 9

[John Kim [snoozes]]

Hello.
I submitted a new commit.  Really hoping that the squash was done correctly.

Comment 10

[Giorgos Logiotatidis [:giorgos]]

Fixed:

https://github.com/mozilla/mozillians/commit/9927ece0240208a49878d9799fe87a0cfc573f3e


Thanks snoozes!

Comment 11

[Matt Brandt [:mbrandt]]

Can you provide minimal steps to test fro QA. I'm not sure I understand the scope of the change.

Comment 12

[William Reynolds [:williamr]]

(In reply to Matt Brandt [:mbrandt] from comment #11)
> Can you provide minimal steps to test fro QA. I'm not sure I understand the
> scope of the change.

It looks like the fix from Giorgos makes the province/state field optional instead of required. The only test for now is that you can create/edit a profile without providing a value in the province/state field.

It would be nice to require the province/state for users who are in the United States. Are there other regions where we should require a province/state?

Comment 13

[Matt Brandt [:mbrandt]]

(In reply to William Reynolds [:williamr] from comment #12) 
> It looks like the fix from Giorgos makes the province/state field optional
> instead of required. The only test for now is that you can create/edit a
> profile without providing a value in the province/state field.

Thanks William, that's what it appeared to be but I didn't want to assume.

> It would be nice to require the province/state for users who are in the
> United States. Are there other regions where we should require a
> province/state?

Honestly .. I don't know :-) perhaps we can reach out to our localizers for some tips.

Comment 14

[Matt Brandt [:mbrandt]]

QA verified on stage - only the Country field is required during new user registration and when editing an existing profile.