Closed
Bug 772479
Opened 12 years ago
Closed 12 years ago
ReferenceError: reference to undefined property aViewport.width since bug #758620
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
Attachments
(1 file)
1.80 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Attachment 636359 [details] [diff] uses aViewport.width/aViewport.height in setViewport, neither of which actually exist (sorry) - as it turns out, the function they call with these values still does something sensible (hurray), but instead, we should use the right values. This seems to have no obvious ill effect, other than an annoying message in the log.
Patch incoming.
Assignee | ||
Comment 1•12 years ago
|
||
Calculate the viewport width/height first and use those variables in both places it's expected.
Attachment #640642 -
Flags: review?(bugmail.mozilla)
Updated•12 years ago
|
Attachment #640642 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/f5ba1d1f6f0e
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f5ba1d1f6f0e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•