Closed
Bug 772502
Opened 12 years ago
Closed 12 years ago
Image slider remains highlighted after a tap is performed over it
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15- fixed, firefox16 verified, firefox17 verified)
VERIFIED
FIXED
Firefox 16
People
(Reporter: xti, Unassigned)
Details
Attachments
(3 files)
148.14 KB,
image/png
|
Details | |
171.73 KB,
image/png
|
Details | |
1.05 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Firefox 16.0a1 (2012-07-10) Device: Galaxy Nexus OS: Android 4.0.4 Steps to reproduce: 1. Open Fennec 2. Browse to https://www.orange.ro/magazin-online/telefoane/sony-xperia-u# 3. Under the main pic on the left, there are 2 little thumbnails. Tap on the first one 4. Tap on the right side of the page Expected result: After step 4, the image is displayed correctly, without any slider highlights. Actual result: After step 4, the highlight border of the slider link is still visible (see screenshot 1). There is no way to make it disappear. Note: On the tablet stock browser, there is no slider highlight at all, as it happens for Native for example (see screenshot 2).
Reporter | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
I hate our focus rings. This kills them. It makes me nervous as well. My main concern is that I have seen cases where focus rings have worked and our tap highlighting has (for some reason) not worked. But I think I'd rather just find those and fix tap highlighting than keep these around.
Attachment #640694 -
Flags: review?(mark.finkle)
Comment 3•12 years ago
|
||
Comment on attachment 640694 [details] [diff] [review] Patch Let's test this out a bit on Nightly
Attachment #640694 -
Flags: review?(mark.finkle) → review+
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e6251d8d492
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Reporter | ||
Comment 6•12 years ago
|
||
This issue was fixed on the latest Nightly build. Closing bug as verified fixed on: Firefox 16.0a1 (2012-07-11) Device: Galaxy Nexus OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox16:
--- → verified
Comment 7•12 years ago
|
||
Comment on attachment 640694 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Forever. Maemo Fennec 1.0 used this for tap highlighting I think. User impact if declined: Orange rings around objects that shouldn't be there Testing completed (on m-c, etc.): This has been on mc for two weeks and I haven't seen any complaints. Its a nice visual improvement in a many places. Risk to taking this patch (and alternatives if risky): Low risk code wise. We use other methods to show what linked is being tapped and apparently they work well enough. String or UUID changes made by this patch: None.
Attachment #640694 -
Flags: approval-mozilla-aurora?
Comment 8•12 years ago
|
||
This is already verified fixed on 16 (which is Aurora) -- are you intending to nominate this for Beta (15) and is 15 even affected?
Comment 9•12 years ago
|
||
Yes and yes. Sorry 'bout that. We've been shipping with this style of tap highlight for a long time.
status-firefox15:
--- → affected
tracking-firefox15:
--- → ?
Comment 10•12 years ago
|
||
Comment on attachment 640694 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Forever. Maemo Fennec 1.0 used this for tap highlighting I think. User impact if declined: Orange rings around objects that shouldn't be there Testing completed (on m-c, etc.): This has been on mc for two weeks and I haven't seen any complaints. Its a nice visual improvement in a many places. Risk to taking this patch (and alternatives if risky): Low risk code wise. We use other methods to show what linked is being tapped and apparently they work well enough. String or UUID changes made by this patch: None.
Attachment #640694 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment 11•12 years ago
|
||
Thanks for updating the status, I don't see that we need to track this since we've already shipped with it but I'll approve for beta landing since it's low risk and improves user experience with mobile.
Updated•12 years ago
|
Attachment #640694 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•12 years ago
|
status-firefox17:
--- → verified
Keywords: checkin-needed
Comment 12•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/ad803799f66b
Keywords: checkin-needed
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•