Closed
Bug 772630
Opened 12 years ago
Closed 12 years ago
JS Profile feature crash if used on startup
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: BenWa, Assigned: BenWa)
Details
Attachments
(1 file)
|
3.18 KB,
patch
|
u443197
:
review+
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
If we try to call 'js::SetRuntimeProfilingStack' before we have a JS runtime and before the JS engine is started and we crash. We start profiling on start up in mobile since we use an environment variable to start. Simple fix is to delay profiling until we get a runtime.
|
Assignee | |
Comment 1•12 years ago
|
||
Also use JS profiling by default on mobile.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #640764 -
Flags: review?(ehsan)
Attachment #640764 -
Flags: review?(acrichton)
Attachment #640764 -
Flags: review?(acrichton) → review+
|
||
Updated•12 years ago
|
Attachment #640764 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/506be1161172
Target Milestone: --- → mozilla16
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/506be1161172
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•