Closed
Bug 772638
Opened 12 years ago
Closed 12 years ago
Disable webapps support on Firefox 15
Categories
(Firefox Graveyard :: Web Apps, defect, P1)
Firefox Graveyard
Web Apps
Tracking
(firefox15+ verified)
VERIFIED
FIXED
Firefox 15
People
(Reporter: jsmith, Assigned: myk)
References
Details
(Whiteboard: [qa!])
Attachments
(1 file, 1 obsolete file)
1.77 KB,
patch
|
Felipe
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per discussion in today's triage, we have decided to disable webapps support on FF 15. Will add rationale for this shortly in a followup comment. This bug tracks to disable webapps for FF 15.
Reporter | ||
Comment 1•12 years ago
|
||
The major rationale for disabling web apps on FF 15 is that there are still blocker patches that was not uplifted, one in particular that was a fundamental API change to desktop web apps as a whole. The docs themselves are not ready for general consumption either, although that affects this decision, but does not finalize it to disable. There's also a bunch of bugs that were not uplifted in general to Aurora, so they still sit in Nightly. There's still outstanding blockers too even right now for targeting FF 16 (currently 6). Therefore, we're hesitant to leave this functionality active and want to disable it. References: Blockers that are not uplifted - https://bugzilla.mozilla.org/buglist.cgi?order=Bug%20Number;resolution=FIXED;status_whiteboard_type=allwordssubstr;query_format=advanced;status_whiteboard=[blocking-webrtdesktop1%2B];bug_status=RESOLVED;bug_status=VERIFIED;bug_status=CLOSED;component=Web%20Apps;component=Webapp%20Runtime;product=Firefox;target_milestone=Firefox%2016;list_id=3666368 Other bugs that are not uplifted - https://bugzilla.mozilla.org/buglist.cgi?order=Bug%20Number;resolution=FIXED;query_format=advanced;bug_status=RESOLVED;bug_status=VERIFIED;bug_status=CLOSED;component=Web%20Apps;component=Webapp%20Runtime;product=Firefox;target_milestone=Firefox%2016;list_id=3666367 Remaining blockers in webrt - https://bugzilla.mozilla.org/buglist.cgi?order=Assignee;resolution=---;status_whiteboard_type=allwordssubstr;status_whiteboard=[blocking-webrtdesktop1%2B];list_id=3665880
tracking-firefox15:
--- → ?
Assignee | ||
Comment 2•12 years ago
|
||
Note: the desktop runtime feature drivers are the ones proposing that webapps be disabled, but it's the Firefox channel drivers who ultimately make the decision. lmandel is going to bring it up in their next regularly-scheduled meeting.
Comment 3•12 years ago
|
||
lmandel did bring it up at the channel meeting and we're good with this decision. Will track this bug to make sure we have everything lined up either pre or post merge on the 16th.
Updated•12 years ago
|
Updated•12 years ago
|
Priority: -- → P1
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → myk
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #641613 -
Flags: review?(felipc)
Updated•12 years ago
|
Attachment #641613 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 641613 [details] [diff] [review] patch v1: disable navigator.mozApps and webapp runtime [Approval Request Comment] Bug caused by (feature/regressing bug #): webapps feature User impact if declined: Users will be exposed to an incomplete/buggy feature. Testing completed (on m-c, etc.): This is equivalent to the patch we previously landed to disable webapps for Firefox 14 (bug 750936), and it is well tested on Firefox 14 beta builds. Risk to taking this patch (and alternatives if risky): There is little risk and no alternatives. String or UUID changes made by this patch: None.
Attachment #641613 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 641613 [details] [diff] [review] patch v1: disable navigator.mozApps and webapp runtime [Triage Comment] Approved for Aurora 15 - please land ASAP to make Monday's merge.
Attachment #641613 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c2504f7b08b3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Reporter | ||
Updated•12 years ago
|
status-firefox15:
--- → fixed
Whiteboard: [qa+]
Assignee | ||
Comment 8•12 years ago
|
||
Reopening, as I backed out the change: https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=c2c2c087c4aa due to test failures: https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=c2504f7b08b3 because I forgot to disable tests for the functionality being disabled.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•12 years ago
|
Reporter | ||
Updated•12 years ago
|
Whiteboard: [qa+]
Assignee | ||
Comment 9•12 years ago
|
||
Here's an updated patch that fixes the test failures. It disables the navigator.mozApps API tests, but it leaves the nsIAppsService tests enabled, so it leaves dom_apps.xpt alone (the patch for Firefox 14 removed it, and my first patch for this bug did the same). dom_apps.xpt provides nsIDOMApplicationRegistry.idl and nsIAppsService.idl (in Firefox 14 it only provided the former, which is why the nsIAppsService tests didn't fail there with the equivalent patch), neither of which seem necessary with webapps disabled. But it also doesn't seem necessary to disable them, as it is sufficient to disable the mozApps API. And disabling them is riskier than disabling the runtime, which has a simple build flag for that purpose. Thus, in the interest of making the lowest-risk change to disable webapps, this patch disables the mozApps API and the runtime, leaving those XPIDL files alone. I built and tested with this patch (I wish we had a TryServer for Aurora!), and all mochitests now pass. I then packaged the installer, installed Aurora with it, and confirmed that the mozApps API and the runtime are not available in the installation.
Attachment #641613 -
Attachment is obsolete: true
Attachment #642278 -
Flags: review?(felipc)
Comment 10•12 years ago
|
||
Comment on attachment 642278 [details] [diff] [review] patch v2: fixes test failures Review of attachment 642278 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Myk, sorry for not remembering about the tests on the previous patch
Attachment #642278 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 642278 [details] [diff] [review] patch v2: fixes test failures Requesting approval of the updated patch, which fixes the test failures from the previously approved patch that caused me to back out that patch. [Approval Request Comment] Bug caused by (feature/regressing bug #): webapps feature User impact if declined: Users will be exposed to an incomplete/buggy feature. Testing completed (on m-c, etc.): This is equivalent to the patch we previously landed to disable webapps for Firefox 14 (bug 750936), and it is well tested on Firefox 14 beta builds. Risk to taking this patch (and alternatives if risky): There is little risk and no alternatives. String or UUID changes made by this patch: None.
Attachment #642278 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 642278 [details] [diff] [review] patch v2: fixes test failures Requesting approval to land this on beta instead now that the merge from aurora to beta has happened. [Approval Request Comment] Bug caused by (feature/regressing bug #): webapps feature User impact if declined: Users will be exposed to an incomplete/buggy feature. Testing completed (on m-c, etc.): This is equivalent to the patch we previously landed to disable webapps for Firefox 14 (bug 750936), and it is well tested on Firefox 14 beta builds. Risk to taking this patch (and alternatives if risky): There is little risk and no alternatives. String or UUID changes made by this patch: None.
Attachment #642278 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Assignee | ||
Updated•12 years ago
|
Summary: Disable webapps support on FF 15 → Disable webapps support on Firefox 15
Comment 13•12 years ago
|
||
Comment on attachment 642278 [details] [diff] [review] patch v2: fixes test failures Approving, please get this in asap so we can have this off in our first beta.
Attachment #642278 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/ad743c3a7d20
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
Whiteboard: [qa+]
Updated•12 years ago
|
Reporter | ||
Updated•12 years ago
|
Updated•12 years ago
|
Comment 15•12 years ago
|
||
Changing status to 'fixed' since the goal of this bug was to disable, and that was accomplished. In other bugs 'disabled' is a state between reported and fixed (hope that makes sense).
Reporter | ||
Updated•12 years ago
|
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•