Closed
Bug 772651
Opened 12 years ago
Closed 12 years ago
change name for temp directory from hard-coding
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: rkd, Assigned: rkd)
References
Details
Attachments
(1 file, 1 obsolete file)
971 bytes,
patch
|
mfinkle
:
review+
blassey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•12 years ago
|
Assignee: nobody → blyakher.a
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 1•12 years ago
|
||
addresses https://bugzilla.mozilla.org/show_bug.cgi?id=769438#c9
Attachment #640812 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #640812 -
Flags: review?(mark.finkle) → review+
Comment 2•12 years ago
|
||
Comment on attachment 640812 [details] [diff] [review] change name for temp directory for image sharing Review of attachment 640812 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/GeckoApp.java @@ +2308,5 @@ > > // Get/Create a temporary direcory > public static File getTempDirectory() { > File sdcard = Environment.getExternalStorageDirectory(); > + File dir = new File(sdcard.getAbsolutePath(), GeckoApp.mAppContext.getPackageName()); File dir = mAppContext.getExternalFilesDir("temp");
Attachment #640812 -
Flags: review+ → review-
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #640812 -
Attachment is obsolete: true
Attachment #640827 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Product: Firefox → Firefox for Android
Version: 16 Branch → unspecified
Comment 4•12 years ago
|
||
Comment on attachment 640827 [details] [diff] [review] change name for temp directory for image sharing I assume this works for "sharing" files. Why not just remove getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly? r+ if blassey likes this too
Attachment #640827 -
Flags: review?(mark.finkle)
Attachment #640827 -
Flags: review?(blassey.bugs)
Attachment #640827 -
Flags: review+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #4) > Comment on attachment 640827 [details] [diff] [review] > change name for temp directory for image sharing > > I assume this works for "sharing" files. Why not just remove > getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly? > > r+ if blassey likes this too This makes a "temp" folder in the external files dir, so that we can reuse that directory for storing other things and not worry about deleting files outside of that /temp.
Assignee: blyakher.a → nobody
Version: unspecified → Firefox 16
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → blyakher.a
Updated•12 years ago
|
Attachment #640827 -
Flags: review?(blassey.bugs) → review+
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd48fae38214
Target Milestone: --- → Firefox 16
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd48fae38214
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•