Closed Bug 772651 Opened 12 years ago Closed 12 years ago

change name for temp directory from hard-coding

Categories

(Firefox for Android Graveyard :: General, defect)

16 Branch
x86
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: rkd, Assigned: rkd)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Assignee: nobody → blyakher.a
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #640812 - Flags: review?(mark.finkle) → review+
Comment on attachment 640812 [details] [diff] [review]
change name for temp directory for image sharing

Review of attachment 640812 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +2308,5 @@
>  
>      // Get/Create a temporary direcory
>      public static File getTempDirectory() {
>          File sdcard = Environment.getExternalStorageDirectory();
> +        File dir = new File(sdcard.getAbsolutePath(), GeckoApp.mAppContext.getPackageName());

File dir = mAppContext.getExternalFilesDir("temp");
Attachment #640812 - Flags: review+ → review-
Attachment #640812 - Attachment is obsolete: true
Attachment #640827 - Flags: review?(mark.finkle)
Product: Firefox → Firefox for Android
Version: 16 Branch → unspecified
Comment on attachment 640827 [details] [diff] [review]
change name for temp directory for image sharing

I assume this works for "sharing" files. Why not just remove getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly?

r+ if blassey likes this too
Attachment #640827 - Flags: review?(mark.finkle)
Attachment #640827 - Flags: review?(blassey.bugs)
Attachment #640827 - Flags: review+
(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 640827 [details] [diff] [review]
> change name for temp directory for image sharing
> 
> I assume this works for "sharing" files. Why not just remove
> getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly?
> 
> r+ if blassey likes this too

This makes a "temp" folder in the external files dir, so that we can reuse that directory for storing other things and not worry about deleting files outside of that /temp.
Assignee: blyakher.a → nobody
Version: unspecified → Firefox 16
Assignee: nobody → blyakher.a
Attachment #640827 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/cd48fae38214
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 773943
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: