773039 - Talkback announces all items in menu when menu is shown

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

This is confusing and chatty for blind users. This does not happen in other apps.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Don't populate menu accessibility event with descendant strings.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Eitan how does this fix work? (Just curious)

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Eitan how does this fix work? (Just curious)

The default implementation of dispatchPopulateAccessibilityEvent calls dispatchPopulateAccessibilityEvent of all the child views, and each view appends text to the event. The override here does not go in to child views.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Bingo. Thanks!

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

Review of attachment 641207 [details] [diff] [review]:
-----------------------------------------------------------------

Eitan, I'd be a little worried about the side effects of this change, but I suspect they'd all be related to accessibility and trust that you'll work through what ever crops up.

Comment 6

[Eitan Isaacson [:eeejay]]

(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 641207 [details] [diff] [review]
> Don't populate menu accessibility event with descendant strings.
> 
> Review of attachment 641207 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Eitan, I'd be a little worried about the side effects of this change, but I
> suspect they'd all be related to accessibility and trust that you'll work
> through what ever crops up.

First, yes. This is a code path that is only reached when accessibility is on. Second, it is relatively well documented here:
http://developer.android.com/guide/topics/ui/accessibility/apps.html#populate-events

Comment 7

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6a5d9afb58e5

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a5d9afb58e5

Comment 9

[Marco Zehe (:MarcoZ)]

Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): default widget implementation
User impact if declined: Whenever a TalkBack user opens the menu, the whole menu items get read to them. Makes working very hard because one does not know which item actually has the focus.
Testing completed (on m-c, etc.): Yes, on a local build.
Risk to taking this patch (and alternatives if risky): None that we can see.
String or UUID changes made by this patch: None.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

[Triage Comment]
Approved for FF15 given that the a11y reward outweighs the near-zero risk to a non-a11y user.

Comment 11

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/71e4b3b43ec9