773124 - Should unify the mock for Windows Registry in mailnews/import/unit/test/.

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

test_oe_settings.js has its own mock of nsIWindowsRegKey, it should use the mock in resouces/mock_windows_reg_factory.js.

test_winmail.js has also its own mock, I will fix it in bug 772712.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 641311 [details] [diff] [review]
Fix

Review of attachment 641311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good - just one suggestion. Thanks hiro!

::: mailnews/import/test/unit/resources/mock_windows_reg_factory.js
@@ +81,5 @@
> +
> +function setup_mock_registry(mockRegistry) {
> +  gUuid = Cc["@mozilla.org/uuid-generator;1"]
> +            .getService(Ci.nsIUUIDGenerator)
> +            .generateUUID().toString();

Let's continue the pattern, and put .toString(); on the next line.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Addressed review comment

Thank you for reviewing!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/8ea8efbb5515