773252 - Unable to edit slug and title of non-English pages

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect, P2)

Description

[Frédéric Bourgeon [:FredB]]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901

Steps to reproduce:

Tried to edit with this url: https://developer-new.mozilla.org/pl/docs/HTML/Element/address$edit


Actual results:

I can edit, but there is no "i" button to change the slug or title.


Expected results:

I should have been able to see the button and change the metadata just like on https://developer-new.mozilla.org/en-US/docs/HTML/Element/address$edit

Comment 1

[Janet Swisher]

There's a "+" in the translation UI next to (the translation of) "Translate Description". Click that to expand the metadata fields.

Comment 2

[David Walsh :davidwalsh]

What Janet said :)

Comment 3

[Frédéric Bourgeon [:FredB]]

After discussion, seems like it's a permission issue. Regular users can change the slug and title of documents on en-US/ but not on other languages.

Comment 4

[Frédéric Bourgeon [:FredB]]

It only affects the translation UI, and not any edit UI. The "i" button can be seen here: https://developer-new.mozilla.org/fr/docs/fr

Comment 5

[John Karahalis [:openjck]]

Thanks for the report, Frédéric. I will be sure we look further into this soon.

Comment 8

[John Karahalis [:openjck]]

Lots of people are reporting this (see the duplicates list). Pretty high priority, I would say.

Comment 10

[David Walsh :davidwalsh]

It appears as though users need "wiki.change_document" permissions to edit the title and slug fields on the translation page.  The user cited earlier today by sheppy, Archaeopteryx, does not have this permission.

Comment 11

[Eric Shepherd [:sheppy]]

Hm, he said he just added some text to the page. He didn't mention doing any slug changes.

Comment 12

[Eric Shepherd [:sheppy]]

Plus he was working on the English version of the page, not a translation.

Comment 13

[David Walsh :davidwalsh]

I'm unclear on what the actual bug is here, if it's not a permission/translate issue.

Comment 14

[John Karahalis [:openjck]]

I don't think any of us completely understand what the underlying problem is.

It could be a permission issue, but it could be an interface issue. If you read the dupes, you'll see that some people may have just not realized that they could click "i" to make these changes.

Comment 15

[Janet Swisher]

Attachment: Screenshot of Polish translation UI for non-privileged account

Comment 16

[Janet Swisher]

The "i" icon is definitely a usability issue, because it's totally not obvious that that should allow you to edit. 

However, that's not the issue here. A non-privileged user doesn't see any icon. I took the attached screenshot from a non-privileged account (not my mozilla.com Persona).

Comment 17

[David Walsh :davidwalsh]

I guess that doesn't explain the "bug" here.  Is the bug that *everyone* should have privs to edit slugs and titles?  Otherwise this is working exactly as it should...

Comment 18

[Luke Crouch [:groovecoder]]

Confirming :davidwalsh comment - this is working as intended. The only way to edit the title & slug of a translation is:

1. At the time of initial translation
2. With the special privilege.

Do we want to change this? Maybe include the original creator of the translation as a person who can edit the title and/or slug?

This would also be affected by the potential refactoring of slugs.

Comment 19

[Eric Shepherd [:sheppy]]

(In reply to Luke Crouch [:groovecoder] from comment #18)
> Confirming :davidwalsh comment - this is working as intended. The only way
> to edit the title & slug of a translation is:
> 
> 1. At the time of initial translation
> 2. With the special privilege.
> 
> Do we want to change this? Maybe include the original creator of the
> translation as a person who can edit the title and/or slug?
> 
> This would also be affected by the potential refactoring of slugs.

Yes, this needs to change. Translators need to be able to correct these translations; if, for example, the English version's title is updated, or there's a translation error in the original version.

Comment 20

[Luke Crouch [:groovecoder]]

Is the title the only/most important field to change? 

The reason I ask - page-moving isn't hurting as badly as it could because only privileged users have the ability to change slugs. i.e., only the docs team, since we haven't given the permission to many others.

Until the page-moving feature is done - including a specific privilege - could we allow anyone/everyone to change just the *title*? Would the at least help the situation while we wait for page-moving?

Then we'll just make sure that page-moving works for translations too.

Comment 21

[Eric Shepherd [:sheppy]]

It's the most important thing, yeah.

Comment 22

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/d811df4c86ac0d647ac267d4f5cd76f91c89f3d9
fix bug 773252; edit title of translations

https://github.com/mozilla/kuma/commit/f31088dc94c89baca8016944c5869e3209b0934c
Merge pull request #591 from groovecoder/edit-translated-title-773252

fix bug 773252; edit title of translations