Closed
Bug 773411
Opened 12 years ago
Closed 12 years ago
when running tests, freeze WebappRT config object after calling confirmInstall()
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: myk, Assigned: myk)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
750 bytes,
patch
|
adw
:
review+
myk
:
checkin+
|
Details | Diff | Splinter Review |
When running tests WebappRT.jsm freezes the configuration object before calling DOMApplicationRegistry.confirmInstall(), but confirmInstall() sets the object's installTime property, which fails after the object is frozen (causing tests to fail). WebappRT.jsm should freeze the configuration object *after* calling confirmInstall().
Attachment #641574 -
Flags: review?(adw)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 641574 [details] [diff] [review] patch v1: freezes object after calling confirmInstall() Review of attachment 641574 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #641574 -
Flags: review?(adw) → review+
|
||
Updated•12 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 641574 [details] [diff] [review] patch v1: freezes object after calling confirmInstall() https://hg.mozilla.org/integration/mozilla-inbound/rev/260f3b5e03f4
Attachment #641574 -
Flags: checkin+
|
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/260f3b5e03f4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•