Closed Bug 773606 Opened 12 years ago Closed 12 years ago

XBL fastload creates XUL element before feeding proto attributes to the protoelement

Categories

(Core :: XBL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

nsXULElement::Create expects that it can check for example mHasClassAttribute value.
But that is just always false if the protoattributes are created after
the real DOM element.
In practice this shouldn't matter much since the XUL element is used within XBL's not-yet-cloned content. But I'm investigating to disable using prototypes in XUL (for anything else but serializing and de-serializing) and noticed this inconsistency.
Attached patch patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=64f421f8386b
Assignee: nobody → bugs
Attachment #641839 - Flags: review?(enndeakin)
Attachment #641839 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/be26e809e6b1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: