Closed
Bug 773626
Opened 12 years ago
Closed 12 years ago
Hash functions for MaskLayerImageCache::PixelRoundedRect and MaskLayerImageCache::MaskLayerImageKey suck
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: nrc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.35 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
PixelRoundedRect::Hash() only looks at mRect, and MaskLayerImageKey::Hash() always returns 0.
Assignee | ||
Comment 1•12 years ago
|
||
sorry, silly mistake
Assignee: nobody → ncameron
Attachment #642075 -
Flags: review?(roc)
Attachment #642075 -
Flags: review?(roc) → review+
Comment 2•12 years ago
|
||
Try run for 60ce617d687d is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=60ce617d687d Results (out of 293 total builds): exception: 7 success: 202 warnings: 14 failure: 70 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ncameron@mozilla.com-60ce617d687d
Comment 3•12 years ago
|
||
Try run for 40ccbe6b037f is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=40ccbe6b037f Results (out of 300 total builds): exception: 1 success: 273 warnings: 20 failure: 6 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ncameron@mozilla.com-40ccbe6b037f
Assignee | ||
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b85bf85ebc06
Comment 5•12 years ago
|
||
Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.
Target Milestone: --- → mozilla17
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b85bf85ebc06
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•