773638 - Erroneous "first time render" message when kumascript is unresponsive

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect, P2)

Description

[Les Orchard [:lorchard]]

When the kumascript service fails, we get the "first time rendering" message. That's incorrect. If a request to the kumascript service during rendering fails, the message should reflect that.

Comment 1

[David Walsh :davidwalsh]

Maybe a bit more info (?):

When I create a template on my local machine, I see the "This document is being rendered for the first time by the system. Please reload this page in a few minutes to see full content." message.  I know that kumascript is working/connected because the "/en-US/docs/Template:CustomCSS?raw=1" address loads just fine.

Despite refreshing, shift-refreshing, etc, I still get this message.  I restarted vagrant, kumascript, celery, and the site itself (./manage.py runserver --forked 0.0.0.0:8000), and I still get this message.  This is blocking me from implementing attachment access within Kumascript templates.

Comment 2

[Les Orchard [:lorchard]]

(In reply to David Walsh :davidwalsh from comment #1)
> Maybe a bit more info (?):

That's pretty much all the info for this bug: When kumascript is not running or doesn't respond, kuma displays that message on a shift-refresh. Maybe you're encountering a different issue than what this bug covers?

> When I create a template on my local machine, I see the "This document is
> being rendered for the first time by the system. Please reload this page in
> a few minutes to see full content." message.  

Create a template or a document? Viewing *templates* shouldn't be rendered through kumascript, and so you shouldn't see that "first time" message while viewing template source at all.

But, for a document, it *is* expected that you'd see the "first time" message for the first time. Especially if you have celeryd and rabbitmq running under vagrant. That's actually the correct use case for the message.

> I know that kumascript is
> working/connected because the "/en-US/docs/Template:CustomCSS?raw=1" address
> loads just fine.

?raw=1 actually means *Kuma* (ie. django) is working fine, not Kumascript. ?raw=1 is what kumascript uses to get raw source from kuma for processing.

> Despite refreshing, shift-refreshing, etc, I still get this message.  I
> restarted vagrant, kumascript, celery, and the site itself (./manage.py
> runserver --forked 0.0.0.0:8000), and I still get this message.  This is
> blocking me from implementing attachment access within Kumascript templates.

Not really sure what's happening on your box, but it does sound like kumascript is not working. Do you have another bug # for the kumascript/attachment stuff? I didn't think that was a launch blocker

Comment 3

[David Walsh :davidwalsh]

Thanks for responding Les!

I see the template in "document" view just fine, it's a document that uses the template that displays the message.  It sounds as though I've not added any value with my initial comment.  

The attachment piece is currently a blocker:

https://bugzilla.mozilla.org/show_bug.cgi?id=773285
https://bugzilla.mozilla.org/show_bug.cgi?id=770727

Comment 4

[John Karahalis [:openjck]]

Looks like this bug is about the ambiguous message rather than KumaScript itself becoming unresponsive. Moving this out of the release as a result.

Correct me if I'm wrong.

Comment 5

[Les Orchard [:lorchard]]

(In reply to John Karahalis [:openjck] from comment #4)
> Looks like this bug is about the ambiguous message rather than KumaScript
> itself becoming unresponsive. Moving this out of the release as a result.
> 
> Correct me if I'm wrong.

Well, it's an incorrect message when kumascript went unresponsive, which delays finding the real cause for problems. I think I might already have a change to address this bug

Comment 6

[Les Orchard [:lorchard]]

https://github.com/mozilla/kuma/pull/406

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/be920c70fa6ce86b80d6f4299689ed97850c5555
fix bug 773638 - Erroneous "first time render" message when kumascript is unresponsive

* Try not to show "first time" or "scheduled" rendering messages when
  there are actually kumascript errors

https://github.com/mozilla/kuma/commit/2ea5080d0d7edfb2e2b46b3da0d465918b7ec823
Merge pull request #406 from lmorchard/first-time-message-on-kumascript-failure-773638

fix bug 773638 - Erroneous "first time render" message when kumascript is unresponsive