773713 - Stop using profile directory for Device Storage testings

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Hmm, any context?

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 641967 [details] [diff] [review]
patch v.1

Review of attachment 641967 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks good, no red flags.  A bit out of my league for what I know.

::: dom/devicestorage/test/devicestorage_common.js
@@ +18,5 @@
> +  try {
> +    const Cc = SpecialPowers.wrap(Components).classes;
> +    const Ci = Components.interfaces;
> +    var directoryService = Cc["@mozilla.org/file/directory_service;1"].getService(Ci.nsIProperties);
> +    var f = directoryService.get("TmpD", Components.interfaces.nsIFile);

do you have access to Ci.nsiFile?

Comment 4

[Doug Turner (:dougt)]

wierd, i didn't.  but I will fix the patch so that it uses the wrapped.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d877d78294

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Sorry, but your push had to be backed out due to compilation errors on all platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db81ae082e7

/builds/slave/m-in-lnx/build/dom/ipc/PContent.ipdl:166: error: ctor for protocol `PDeviceStorageRequest', which is not managed by protocol `PContent'
Specification is not well typed.

Comment 7

[Doug Turner (:dougt)]

bad rebase - https://hg.mozilla.org/integration/mozilla-inbound/rev/ebaadef40580

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebaadef40580