773774 - Don't clone document for reader mode check

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: patch

We now avoid any DOM manipulations when checking readability, so there's no need to clone the document.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch v2

forgot to qref

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 642013 [details] [diff] [review]
patch v2

># HG changeset patch
># Parent 7c1e2b2a718357bf9d045aa59ede37dd97251cb5
># User Brian Nicholson <[e-mail]>
>
>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js
>--- a/mobile/android/chrome/content/browser.js
>+++ b/mobile/android/chrome/content/browser.js
>@@ -6353,20 +6353,18 @@ let Reader = {
>       // First, try to find a cached parsed article in the DB
>       this.getArticleFromCache(url, function(article) {
>         if (article) {
>           this.log("Page found in cache, page is definitely readable");
>           callback(true);
>           return;
>         }
> 
>-        // FIXME: Make the readability check not require a separate copy
>-        // of the document by making the operation fully non-destructive.
>-        let doc = tab.browser.contentWindow.document.cloneNode(true);
>         let uri = Services.io.newURI(url, null, null);
>+        let doc = tab.browser.contentWindow.document;
> 
>         let readability = new Readability(uri, doc);
>         callback(readability.check());
>       }.bind(this));
>     } catch (e) {
>       this.log("Error checking tab readability: " + e);
>       callback(false);
>     }

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a5b74af104b8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a5b74af104b8

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 642013 [details] [diff] [review]
patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Reader parse will be slower
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10de8a7d727b