773842 - Fix build warnings under content/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Mounir Lamouri (:mounir)]

David, do you think you could try to add FAIL_ON_WARNINGS = 1 at some places in content/ subdirectories?

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 643524 [details] [diff] [review]
Patch

Review of attachment 643524 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit below fixed.

BTW, make sure to send this to try with "-p all", "-p macosx" isn't going to be enough.

::: content/base/src/nsContentIterator.cpp
@@ +1199,5 @@
>    PRInt32 endOffset = mRange->EndOffset();
>    MOZ_ASSERT(mCommonParent && startParent && endParent);
>    // Bug 767169
> +  MOZ_ASSERT((PRUint32)startOffset <= startParent->Length() &&
> +             (PRUint32)endOffset <= endParent->Length());

PRUint32(foo) is more C++'y.

Comment 5

[David Zbarsky (:dzbarsky)]

Pushed with your comment.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0dc2d401d71

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0dc2d401d71