Closed Bug 77386 Opened 23 years ago Closed 23 years ago

nsLDAPAutoCompleteSession should process filterTemplate param

Categories

(Directory :: LDAP XPCOM SDK, defect, P1)

Product:
Directory
Component:
LDAP XPCOM SDK
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Whiteboard: [PDT+] have r=, sr=, awaiting a=)

Attachments

(4 files)

Implement processing of filter templates patch, v1.
14.06 KB, patch
Details | Diff | Splinter Review
patch v2, addressing various suggestions from leif
14.12 KB, patch
Details | Diff | Splinter Review
patch 2a, changes to mailnews JS
1.40 KB, patch
Details | Diff | Splinter Review
patch v3
15.37 KB, patch
Details | Diff | Splinter Review 
And this should probably also be hooked up to a hidden pref in the JS in mailnew
that calls nsLDAPAutoCompleteSession, once it does.
Blocks: 70933
Status: NEW → ASSIGNED
Depends on: 74896
No longer blocks: 70933
Blocks: 17880
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → mozilla0.9.1
reassign to Olga as QA Contact
QA Contact: yulian → olgac
Target Milestone: mozilla0.9.1 → mozilla0.9.2
No longer depends on: 74896
Blocks: 85315
See bug 85315 for a better explanation of what's going on here.  This bug
(77386) is for implementing the functionality of allowing the user to specify
the LDAP search filter template via hidden pref.  83515 is discussion about what
the default search filter template should be.  Only this patch has any actual
code associated with it.
OK, I've got working code in my tree.  Need to sand the corners off a few edge
cases; then I'll attach a patch here.
Whiteboard: code in hand; patch forthcoming
PDT+ per 6/12 mtg.
Whiteboard: code in hand; patch forthcoming → [PDT+] code in hand; patch forthcoming
r=leif
Forgot to attach the JS changes earlier; here they are.
Keywords: patch, review
Whiteboard: [PDT+] code in hand; patch forthcoming → [PDT+] have partial r=
r=srilatha on patch 2a
Whiteboard: [PDT+] have partial r= → [PDT+] have r=, awaiting sr=
sr=bienvenu
Attached patch patch v3 — — Splinter Review 

    
    

    
  
OK, this latest patch has two tiny changes in it:

* used some temporaries to appease Mac compiler lameness

* updated to the CVS tip after the SearchExt API changes

    
  
Whiteboard: [PDT+] have r=, awaiting sr= → [PDT+] have r=, sr=, awaiting a=

    
    

    
  
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
verified on WinNT 4.0, MacOS 9.1, Linux RH 7.1 with  2001062004, 2001062008, 
2001062111 builds
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: