Closed
Bug 773933
Opened 12 years ago
Closed 12 years ago
Remove libs rules from browser/components/sessionstore/src/Makefile.in
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.32 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #642195 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 642195 [details] [diff] [review] Patch v1 Review of attachment 642195 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/sessionstore/src/Makefile.in @@ +31,1 @@ > SessionStore.jsm \ Fix the indent while you're here? ::: config/rules.mk @@ +1392,5 @@ > ################################################################################ > +# Copy each element of EXTRA_JS_MODULES to JS_MODULES_PATH, or > +# $(FINAL_TARGET)/modules if that isn't defined. > +ifndef JS_MODULES_PATH > +JS_MODULES_PATH := $(FINAL_TARGET)/modules You could just write this as JS_MODULES_PATH ?= $(FINAL_TARGET)/modules
Attachment #642195 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c6ae36a7f8a9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Comment 4•12 years ago
|
||
Backed out with the mass tree revert to get rid of the OS X M5 orange: https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d6318b897437
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•