Closed
Bug 773956
Opened 12 years ago
Closed 12 years ago
toolkit/crashreporter/test/unit_ipc/xpcshell.ini is included with an invalid condition
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Unfocused, Assigned: jdm)
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
toolkit/crashreporter/test/unit_ipc/xpcshell.ini is included here: https://hg.mozilla.org/mozilla-central/annotate/6f14db95942b/testing/xpcshell/xpcshell.ini#l103 With the condition: skip-if.os == "linux" || !crashreporter Which AFAIK is invalid syntax, and needs to be the following for it to work: skip-if = os == "linux" || !crashreporter However, that was landed 9 months ago. So is the intent of the condition valid, or should it just be removed?
|
Assignee | |
Comment 1•12 years ago
|
||
I did some testing and found that the conditions as applied don't do anything. Therefore, these modifications should have no effective difference.
Attachment #642230 -
Flags: review?(jmaher)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → josh
|
||
Comment 2•12 years ago
|
||
Comment on attachment 642230 [details] [diff] [review] Fix up invalid syntax and configurations in xpcshell.ini. Review of attachment 642230 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #642230 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/054016215c5e
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/054016215c5e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•