Closed
Bug 774240
Opened 12 years ago
Closed 12 years ago
data URI parsing mis-detects "base64" parameter as extension
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: julian.reschke, Assigned: felix_moeller)
References
Details
Attachments
(1 file, 1 obsolete file)
1.51 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
"data" URIs (RFC 2397) allow extension parameters; they could be called "base64" but must not be confused with the "base64" extension. For instance; data:text/plain;base64,... *is* the base64 extension, while data:text/plain;base64=xy,... is not (as indicated by the "=" sign). See test case: <http://greenbytes.de/tech/tc/datauri/#base64param> This works properly in Chrome and Opera.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #642551 -
Flags: review?(rjesup)
Comment 2•12 years ago
|
||
Comment on attachment 642551 [details] [diff] [review] Proposed patch, including test case Change the two constant strings to single a #define BASE64_URI_TAG ";base64" (or some such name), and r+
Attachment #642551 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 3•12 years ago
|
||
thanks for the review Randell!
Attachment #642551 -
Attachment is obsolete: true
Attachment #642585 -
Flags: review?(rjesup)
Updated•12 years ago
|
Attachment #642585 -
Flags: review?(rjesup) → review+
Reporter | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eac3221e3e86 Thanks for the patch, Felix! One request - for future patches, please follow the directions below. It makes life easier for those committing on your behalf. Thanks again! https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eac3221e3e86
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•