774271 - improve DNS logging

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Josh Aas]

Attachment: fix v1.0

I'd like to make some modest improvements to DNS logging.

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 642578 [details] [diff] [review]
fix v1.0

Review of attachment 642578 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me.

::: netwerk/dns/nsHostResolver.cpp
@@ +950,5 @@
>  
>  void
>  nsHostResolver::ThreadFunc(void *arg)
>  {
> +    LOG(("DNS lookup thread starting execution.\n"));

Would it be overkill to get the thread id (PR_GetThreadID) for the logs in ThreadFunc? Called functions don't look like they have logs.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

PR_LOG adds the thread id in its output, doesn't it?

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Oh! That's what that is :) Then never mind what I wrote.

Comment 4

[Josh Aas]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7fe11a265ac5

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

:-) See http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/io/prlog.c#456

The first number is the PRThread->id, the second number is the PRThread*. I believe that makes the first number the OS thread ID.

Comment 6

[Steve Workman [:sworkman] (INACTIVE)]

Thanks Christian :)

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7fe11a265ac5