Closed Bug 774463 Opened 12 years ago Closed 12 years ago

figure out why CheckNewScriptProperties doesn't work on nested functions

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: luke, Unassigned)

Details

(Whiteboard: [js:t]) 

The non-reentrant closure optimization patch added a check to CheckNewScriptProperties to bail on nested functions:

  https://hg.mozilla.org/mozilla-central/rev/d9650bc4da1a#l12.394

when this optimization was removed in bug 765956, this check was removed.  However, this caused regressions (bug 773929).  The quick fix was to go back to disallowing this function on nested functions (now using script->enclosingStaticScope), but it would be really good to understand why this restriction is necessary in the first place.
Whiteboard: [js:t]
I tracked it down to bug 783396.  Indeed, the nested functions were a red herring and only served to turn off the new-script analysis on the particular YouTube script in question.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.