Closed Bug 774550 Opened 12 years ago Closed 11 years ago

DOM bindings don't get rebuilt if their dependencies change but the text doesn't change

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 784812

People

(Reporter: ehsan.akhgari, Unassigned)

Details

I did the following:

* edit dom/bindings/Bindings.conf.
* edit dom/webidl/Perfromance*.webidl
* make -C objdir/dom

make finished running without rebuilding anything.
Hmm.  Bindings.conf is explicitly listed in bindinggen_dependencies.

Did the changes lead to exactly the same code being generated?  There's some weirdness where we don't create the new C++ and header files if they end up being string-identical to what we used to have....
(In reply to comment #1)
> Hmm.  Bindings.conf is explicitly listed in bindinggen_dependencies.
> 
> Did the changes lead to exactly the same code being generated?  There's some
> weirdness where we don't create the new C++ and header files if they end up
> being string-identical to what we used to have....

Hmm, maybe.  I was trying to move the infallible annotations to the WebIDL files, and I guess that didn't change the exact code generated, right?  Still, this is totally unintuitive.
Yeah, indeed, moving the annotations wouldn't change the code.

I agree it's screwed up.  I thought Kyle had an existing bug on it...
OK, let's make this that bug, then!
Summary: Changing dom/bindings/Bindings.conf and dom/webidl/foo.webidl doesn't trigger a rebuild → DOM bindings don't get rebuilt if their dependencies change but the text doesn't change
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.