Closed
Bug 774558
Opened 12 years ago
Closed 12 years ago
Typo in pymake.functions.SubstitutionRef.__repr__
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: gps, Assigned: gps)
Details
(Whiteboard: [pymake])
Attachments
(1 file)
|
874 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
There is a typo in pymake.functions.SubstitutionRef.__repr__ that causes this function to always raise. This prevents the tests/parsertests.py tests from passing. It makes me wonder if the pymake tests should be hooked up to the build system. Maybe the make/pymake comparison ones would be a little expensive. But, the unit tests execute in just a few milliseconds.
Attachment #642842 -
Flags: review?(khuey)
|
||
Comment 1•12 years ago
|
||
I would support running them as part of the regular build.
Comment on attachment 642842 [details] [diff] [review] Fix typo Review of attachment 642842 [details] [diff] [review]: ----------------------------------------------------------------- doh!
Attachment #642842 -
Flags: review?(khuey) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/985e2a9dc8fb https://hg.mozilla.org/integration/mozilla-inbound/rev/a10834675f4d
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a10834675f4d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•