774731 - Previous conversations sometimes not displayed

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

I've debugged a few cases where the "Daily currently doesn't have any previous conversations stored for this contact." panel was displayed instead of an existing previous conversation.

It happened when selecting a contact with a previous conversation, then a contact without previous conversation, then selecting the contact with a previous conversation again. This is because in my patch for bug 754914 I prevented redisplaying a previous conversation if it was already displayed in the browser, but I forgot to still ensure the log panel is visible.

The same thing can happen for the "Search result" item: the log panel isn't always shown correctly when reselecting that item.

And a last case causing a similar problem: closing the "search result" conversation, which actually just hides it. This attempts to select another conversation, but the mousedown event handler of listbox.xml immediately reselects it even though it is hidden, so when displaying it again the 'select' event isn't fired, as the item is already selected.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 643016 [details] [diff] [review]
Patch

Review of attachment 643016 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - and I can confirm that this fixes the bug.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 643016 [details] [diff] [review]
Patch

Yeah, I really think we want to have this on aurora/beta.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/b25917a2622e
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/b423b5dcf058
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/20b6906240f4