Closed
Bug 774987
Opened 12 years ago
Closed 12 years ago
Memory leak and unnecessary copies in PresShell touch-event handling code
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: cjones, Assigned: wesj)
Details
Attachments
(1 file, 1 obsolete file)
2.71 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Memory leak http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#5559 Unnecessary copies http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#6503 http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#6553 (Since nsIDOMTouch is cycle collected, I think these unref's can be relatively expensive.) Wes, want to grab these?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → wjohnston
Comment 2•12 years ago
|
||
Comment on attachment 643424 [details] [diff] [review] Patch Why not nsPoint pt(aTouch->mRefPoint.x, aTouch->mRefPoint.y); widget = frame->GetView()->GetNearestWidget(&pt);
Assignee | ||
Comment 3•12 years ago
|
||
I'm fine with that. Tested on Google maps. Everythings still good.
Attachment #643424 -
Attachment is obsolete: true
Attachment #643424 -
Flags: review?(bugs)
Attachment #643427 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #643427 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1341ea4e3c80
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1341ea4e3c80
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•