Closed Bug 774987 Opened 12 years ago Closed 12 years ago

Memory leak and unnecessary copies in PresShell touch-event handling code

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: cjones, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → wjohnston
Attached patch Patch (obsolete) — Splinter Review
I think this is right?
Attachment #643424 - Flags: review?(bugs)
Comment on attachment 643424 [details] [diff] [review]
Patch

Why not 

nsPoint pt(aTouch->mRefPoint.x, aTouch->mRefPoint.y);
widget = frame->GetView()->GetNearestWidget(&pt);
Attached patch Patch v2Splinter Review
I'm fine with that. Tested on Google maps. Everythings still good.
Attachment #643424 - Attachment is obsolete: true
Attachment #643424 - Flags: review?(bugs)
Attachment #643427 - Flags: review?(bugs)
Attachment #643427 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/1341ea4e3c80
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: