Closed
Bug 775076
Opened 12 years ago
Closed 12 years ago
Installing DLLs from WIN32_REDIST_DIR uses vim "install" command in MozillaBuild 1.6
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: imphil, Unassigned)
Details
Attachments
(1 file)
685 bytes,
text/plain
|
Details |
I am using MozillaBuild 1.6 (the latest, without modifications) and have a mozconfig with WIN32_REDIST_DIR="$VCINSTALLDIR\redist\x86\Microsoft.VC100.CRT" In this version MozillaBuild the vim-directory is in the path before the msys path. The vim-Directory (C:\mozilla-build\vim\vim72) contains a file called "install.exe". The build/win32/Makefile.in installs the win32 crts by install --preserve-timestamps ... and uses so the vim install.exe, which of course does not work. This has been noted a couple times before (e.g. bugs 533418, 506020), but the solution was either to rename/remove vim's install.exe or to change the path. It's not quite clear to me why we could not simply use $(INSTALL) instead to make sure this problem does not come up again (like it just did for me)? Proposed patch is attached.
Reporter | ||
Updated•12 years ago
|
Attachment #643361 -
Flags: review?(ted.mielczarek)
Comment 1•12 years ago
|
||
I have MozillaBuild 1.6 installed, and /bin/install shows up before vim in my $PATH. That was what bug 506020 fixed. How is yours broken? $ which install /bin/install.exe
Reporter | ||
Comment 2•12 years ago
|
||
Hm, I just did a fresh install of MozillaBuild and now everything is fine. For reference, that's how it looked before (MozillaBuild is started by start-msvc10.bat in both cases): BEFORE REINSTALL ================================== philipp@LMU-4B80E313820 ~ $ which install /c/mozilla-build/vim/vim72/install.exe philipp@LMU-4B80E313820 ~ $ echo $PATH /local/bin:/c/mozilla-build/wget:/c/mozilla-build/7zip:/c/mozilla-build/blat261/ full:/c/mozilla-build/python:/c/mozilla-build/svn-win32-1.6.3/bin:/c/mozilla-bui ld/upx203w:/c/mozilla-build/emacs-22.3/bin:/c/mozilla-build/info-zip:/c/mozilla- build/nsis-2.22:/c/mozilla-build/nsis-2.33u:/c/mozilla-build/nsis-2.46u:/c/mozil la-build/wix-351728:/c/mozilla-build/hg:/c/mozilla-build/python/Scripts:/c/mozil la-build/kdiff3:/c/mozilla-build/yasm:/local/bin:/c/mozilla-build/wget:/c/mozill a-build/7zip:/c/mozilla-build/blat261/full:/c/mozilla-build/python25:/c/mozilla- build/svn-win32-1.6.3/bin:/c/mozilla-build/upx203w:/c/mozilla-build/emacs-22.3/b in:/c/mozilla-build/info-zip:/c/mozilla-build/nsis-2.22:/c/mozilla-build/nsis-2. 33u:/c/mozilla-build/hg:/c/mozilla-build/python25/Scripts:/c/mozilla-build/kdiff 3:/c/mozilla-build/vim/vim72:.:/usr/local/bin:/mingw/bin:/bin:/e/msvc10/VSTSDB/D eploy:/e/msvc10/Common7/IDE/:/e/msvc10/VC/BIN:/e/msvc10/Common7/Tools:/c/WINDOWS /Microsoft.NET/Framework/v4.0.30319:/c/WINDOWS/Microsoft.NET/Framework/v3.5:/e/m svc10/VC/VCPackages:/c/Programme/HTML Help Workshop:/c/Programme/Microsoft SDKs/ Windows/v7.0A/bin/NETFX 4.0 Tools:/c/Programme/Microsoft SDKs/Windows/v7.0A/bin: /c/WINDOWS/System32:/c/WINDOWS:/c/WINDOWS/System32/Wbem:/c/mozilla-build/moztool s/bin:/c/mozilla-build/vim/vim72 ================================== AFTER REINSTALL ================================== philipp@LMU-4B80E313820 ~ $ which install /bin/install.exe philipp@LMU-4B80E313820 ~ $ echo $PATH /local/bin:/c/mozilla-build/wget:/c/mozilla-build/7zip:/c/mozilla-build/blat261/ full:/c/mozilla-build/python:/c/mozilla-build/svn-win32-1.6.3/bin:/c/mozilla-bui ld/upx203w:/c/mozilla-build/emacs-22.3/bin:/c/mozilla-build/info-zip:/c/mozilla- build/nsis-2.22:/c/mozilla-build/nsis-2.33u:/c/mozilla-build/nsis-2.46u:/c/mozil la-build/wix-351728:/c/mozilla-build/hg:/c/mozilla-build/python/Scripts:/c/mozil la-build/kdiff3:/c/mozilla-build/yasm:.:/usr/local/bin:/mingw/bin:/bin:/e/msvc10 /VSTSDB/Deploy:/e/msvc10/Common7/IDE/:/e/msvc10/VC/BIN:/e/msvc10/Common7/Tools:/ c/WINDOWS/Microsoft.NET/Framework/v4.0.30319:/c/WINDOWS/Microsoft.NET/Framework/ v3.5:/e/msvc10/VC/VCPackages:/c/Programme/HTML Help Workshop:/c/Programme/Micros oft SDKs/Windows/v7.0A/bin/NETFX 4.0 Tools:/c/Programme/Microsoft SDKs/Windows/v 7.0A/bin:/c/WINDOWS/System32:/c/WINDOWS:/c/WINDOWS/System32/Wbem:/c/mozilla-buil d/moztools/bin:/c/mozilla-build/vim/vim72 ================================== I just did a folder-compare with WinMerge and it seems that some old files of a previous MozillaBuild install were laying around, even though the installer says "Everything in the target directory will be overwritten" :) Anyway, Ted, please close this as WONTFIX or do you want to take the patch anyway?
Comment 3•12 years ago
|
||
If it ain't broke, don't fix it.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Updated•12 years ago
|
Attachment #643361 -
Flags: review?(ted.mielczarek)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•