775408 - nsIDocShell Browser/App attributes bikeshedding party

Status: RESOLVED DUPLICATE of bug 802366

(Core :: DOM: Navigation, defect)

Description

[Mounir Lamouri (:mounir)]

Follow-up from bug 774957.

We should discuss the naming of the attributes/methods here... if we want to.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The only thing I really care about is that the two properties that map to the security model have sane names that we can refer to in all security model docs. That way code is easier to understand for people that are implementing and using the security model.

Hence I would like there to be a property .appId which returns the app we are currently "under", and a .inBrowser or .inBrowserElement or .browserContent which returns true iif we are inside a non-app <iframe mozbrowser>.

I'll leave all other names up to the docShell peers.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: First blood

Comment 3

[Justin Lebar (not reading bugmail)]

>diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
>--- a/docshell/base/nsDocShell.cpp
>+++ b/docshell/base/nsDocShell.cpp
>@@ -12021,17 +12021,17 @@ nsDocShell::GetCanExecuteScripts(bool *a
> #endif // DEBUG
>       } while (treeItem && docshell);
>   }
> 
>   return NS_OK;
> }
> 
> NS_IMETHODIMP
>-nsDocShell::SetIsBrowser()
>+nsDocShell::SetIsBrowserElement()
> {
>     if (mIsBrowserFrame) {
>         NS_ERROR("You should not call SetIsBrowser() more than once.");

Fix this.

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Justin Lebar [:jlebar] from comment #3)
> >diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
> >--- a/docshell/base/nsDocShell.cpp
> >+++ b/docshell/base/nsDocShell.cpp
> >@@ -12021,17 +12021,17 @@ nsDocShell::GetCanExecuteScripts(bool *a
> > #endif // DEBUG
> >       } while (treeItem && docshell);
> >   }
> > 
> >   return NS_OK;
> > }
> > 
> > NS_IMETHODIMP
> >-nsDocShell::SetIsBrowser()
> >+nsDocShell::SetIsBrowserElement()
> > {
> >     if (mIsBrowserFrame) {
> >         NS_ERROR("You should not call SetIsBrowser() more than once.");
> 
> Fix this.

Bug 776195

Comment 5

[Justin Lebar (not reading bugmail)]

> > >     if (mIsBrowserFrame) {
> > >         NS_ERROR("You should not call SetIsBrowser() more than once.");
> > 
> > Fix this.
> >
> Bug 776195

Sorry, I just meant that it should say /SetIsBrowserElement/.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3dfc809486f5

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to Justin Lebar [:jlebar] from comment #5)
> > > >     if (mIsBrowserFrame) {
> > > >         NS_ERROR("You should not call SetIsBrowser() more than once.");
> > > 
> > > Fix this.
> > >
> > Bug 776195
> 
> Sorry, I just meant that it should say /SetIsBrowserElement/.

Just pushed something to fix that.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c07793b7dc10

Comment 9

[Justin Lebar (not reading bugmail)]

This is basically subsumed by bug 802366.