775451 - Choose a suitable pre-render size for async pan/zoomed content

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

In the initial landing, we're only drawing the window size, which means each pan results in "checkerboarding".  It's relatively easy to render more content, but we need to pass more information from gecko to apzc and fix up some offset calculations.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Reduce amount of diagonal checkerboarding

We'll probably have to keep tweaking this forever, but this patch should reduce diagonal checkerboarding which seems to be the worst thing we're still experiencing. I also added code to take into account the velocity directly. If we're going really fast, we try to prerender a larger area than if we're going slower. This is again more useful diagonally since we may be going fast along one axis and slow along another, in which case we want to prerender less of one and more of another.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 648963 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

>diff --git a/gfx/layers/ipc/AsyncPanZoomController.cpp b/gfx/layers/ipc/AsyncPanZoomController.cpp

>+    if (fabsf(velocity.x) > MIN_SKATE_SPEED) {

Factor out this code and share it.

r=me with that.

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Reduce amount of diagonal checkerboarding

Addressed review comments, r+ carried.

Comment 4

[Doug Sherk (:drs) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32cc8084d1b7

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d8878c0bd67c - something in that push made Linux oddly unhappy.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/32cc8084d1b7

Comment 7

[Doug Sherk (:drs) (inactive)]

This was backed out.

Comment 8

[Doug Sherk (:drs) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e0038507ff

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a2e0038507ff