775475 - Main menu breaks Alt-← navigation on mozilla.org when a menu is open

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Clochix]

Go to a page on mozilla.org with a top menu, like http://www.mozilla.org/en-US/firefox/all.html
Hover the top menu with your mouse pointer. The menu opens.
Now try to go back to previous page with the keyboard shortcut Alt-←. The page intercepts the key and navigate inside the menu.

Tabzilla.initSubmenu in tabzilla.js should test id event.altKey is false.

Comment 1

[raymond [:retornam] (inactive)]

(In reply to Clochix from comment #0)
> Go to a page on mozilla.org with a top menu, like
> http://www.mozilla.org/en-US/firefox/all.html
> Hover the top menu with your mouse pointer. The menu opens.
> Now try to go back to previous page with the keyboard shortcut Alt-←. The
> page intercepts the key and navigate inside the menu.
> 
> Tabzilla.initSubmenu in tabzilla.js should test id event.altKey is false.

I tried this OS X 10.7 and wasn't able to reproduce this

Comment 2

[Clochix]

I've reproduced this in both Firefox and Chromium, on GNU/Linux and MS/Windows.
AFAIK, OS X uses Cmd instead of Alt to navigate into history, so maybe MacOS is not affected by this problem.

Comment 3

[Anthony Ricaud (:rik)]

Confirmed this is happening on OS X too. We need to check if a modifier key is used. The code lives in js/nav-main.js.

I can mentor anyone who wants to fix this.

Comment 4

[Anthony Ricaud (:rik)]

Also, this is not a problem with Tabzilla.

Comment 5

[Victor Mejia]

Is this bug taken?

Comment 6

[Kafji]

(In reply to Victor Mejia from comment #5)
> Is this bug taken?

Yes, I'm working on this.
But I've had trouble to run Bedrock in my local and still trying to resolve it.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d60ddf09fcab2824803774dfdc21ef366ab78d26
Main menu breaks Alt-← navigation

With the menu open, don't catch key events if a modifier key is pressed

fix bug 775475

Comment 8

[Anthony Ricaud (:rik)]

I backported this to the PHP website too in r108175. Pushed to stage with r108176 and to production with r108177.

I'll push the Bedrock side to production later today.

Comment 9

[Anthony Ricaud (:rik)]

Pushed to production on Bedrock too.