775509 - Enable tooltool for all mozilla-central based projects

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Ed Morley [:emorley]]

Tried clobber, didn't help:

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13667718&tree=Profiling
https://tbpl.mozilla.org/php/getParsedLog.php?id=13669328&tree=Profiling
https://tbpl.mozilla.org/php/getParsedLog.php?id=13668439&tree=Services-Central
https://tbpl.mozilla.org/php/getParsedLog.php?id=13668464&tree=Services-Central

{
Adding configure options from /builds/slave/srv-cen-osx64/build/.mozconfig:
  --target=i386-apple-darwin10
  --with-macos-sdk=/Developer/SDKs/MacOSX10.6.sdk
  --enable-stdcxx-compat
  --enable-application=browser
  --enable-update-channel=
  --enable-update-packaging
  --enable-codesighs
  --disable-install-strip
  --enable-signmar
  --enable-profiling
  --enable-js-diagnostics
  --with-macbundlename-prefix=Firefox
  --enable-warnings-as-errors
creating cache ./config.cache
checking host system type... /builds/slave/srv-cen-osx64/build/build/autoconf/config.guess: line 1251: /builds/slave/srv-cen-osx64/build/clang/bin/clang: No such file or directory
i386-apple-darwin11.2.0
checking target system type... i386-apple-darwin10
checking build system type... i386-apple-darwin11.2.0
checking for mawk... no
checking for gawk... no
checking for nawk... no
checking for awk... awk
checking for /builds/slave/srv-cen-osx64/build/clang/bin/clang... /builds/slave/srv-cen-osx64/build/clang/bin/clang -arch i386
checking for /builds/slave/srv-cen-osx64/build/clang/bin/clang++... /builds/slave/srv-cen-osx64/build/clang/bin/clang++ -arch i386
checking for perl5... no
checking for perl... /usr/bin/perl
checking for gcc... /builds/slave/srv-cen-osx64/build/clang/bin/clang -arch i386
checking whether the C compiler (/builds/slave/srv-cen-osx64/build/clang/bin/clang -arch i386  ) works... no
configure: error: installation or configuration problem: C compiler cannot create executables.
*** Fix above errors and then restart with               "make -f client.mk build"
make[3]: *** [configure] Error 1
make[2]: *** [obj-firefox/i386/Makefile] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
}

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

They are not running tooltool :-(

Comment 2

[Rail Aliiev [:rail]]

Need to enable tooltool on all project branches tracking mozilla-central.

Comment 3

[Ed Morley [:emorley]]

Also ionmonkey:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13665223&tree=Ionmonkey

UX:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13644845&tree=UX

Holly:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13647888&tree=Holly

Plus any twigs/project repos that haven't yet pulled in the switching changeset, so aren't yet burning.

Comment 4

[Rail Aliiev [:rail]]

Attachment: run tooltool related steps if manifests exist

Run tooltool related steps only the manifest exists. Configs (the next patch) become much simpler.

Comment 5

[Rail Aliiev [:rail]]

Attachment: configs

Move tooltool manifest to platform variables.

Comment 6

[Rail Aliiev [:rail]]

I tested the patches in staging for 3 type of builds: no manifest, empty manifest and with proper manifest. All passed.

Comment 7

[Chris AtLee [:catlee]]

Comment on attachment 643882 [details] [diff] [review]
run tooltool related steps if manifests exist

Review of attachment 643882 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is better done as a (much simpler) client side script.

Comment 8

[Rail Aliiev [:rail]]

Attachment: script

Comment 9

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

worked fine in staging for the previous biuld types.

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 643911 [details] [diff] [review]
script

http://hg.mozilla.org/build/tools/rev/726a439dc568

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 643912 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/b21b584125f2

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 643883 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/1d2a42c19fc7

Comment 13

[Rail Aliiev [:rail]]

Attachment: project branches cleanup

tested as well

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 643929 [details] [diff] [review]
project branches cleanup

http://hg.mozilla.org/build/buildbot-configs/rev/df074305aee2

Comment 15

[Rail Aliiev [:rail]]

In production.

I checked some branches (profiling, Ionmonkey, services-central), retriggered the failed builds. They are still in progress, but passed the tooltool related step and unpacked clang.