775661 - [AccessFu] Add dump tree and accessible states methods to logger

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Added dump tree Logger method, and states to string function.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 643935 [details] [diff] [review]
Added dump tree Logger method, and states to string function.

Review of attachment 643935 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/Utils.jsm
@@ +168,5 @@
> +  },
> +
> +  statesToString: function statesToString(aAccessible) {
> +    let [state, extState] = Utils.getStates(aAccessible);
> +    let statesArray = [];

I'd probably call it stringArray, or strings, but not stingRay because that would be silly.

Comment 3

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/69a69e2a873d

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 643935 [details] [diff] [review]
> Added dump tree Logger method, and states to string function.
> 
> Review of attachment 643935 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/Utils.jsm
> @@ +168,5 @@
> > +  },
> > +
> > +  statesToString: function statesToString(aAccessible) {
> > +    let [state, extState] = Utils.getStates(aAccessible);
> > +    let statesArray = [];
> 
> I'd probably call it stringArray, or strings, but not stingRay because that
> would be silly.

LOL. Changed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69a69e2a873d