Closed Bug 775740 Opened 12 years ago Closed 12 years ago

PromptListAdapter extends ArrayAdapter but reimplements its existing functionality

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file)

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/PromptService.java#470

Specifically, mList is used instead of the existing ArrayAdapter methods. Thus, several methods are overridden which do not need to be (getCount, getItem, getItemId, perhaps more).

Also, getView should have the @Override annotation.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
I think I hit all of the reimplemented functionality.
Attachment #644028 - Flags: review?(wjohnston)
Comment on attachment 644028 [details] [diff] [review]
Patch

Review of attachment 644028 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup! Thanks!
Attachment #644028 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/b154dfeb6905
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.