Closed
Bug 775844
Opened 12 years ago
Closed 12 years ago
Need to include constructor signature types when we make up our lists of types to examine
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
9.97 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Otherwise, for example, using a union type in a constructor argument doesn't actually pick it up as a type to generate union stuff for.
Assignee | ||
Comment 1•12 years ago
|
||
Also includes some distinguishability fixes
Attachment #644173 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [need review]
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #644214 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Attachment #644173 -
Attachment is obsolete: true
Attachment #644173 -
Flags: review?(peterv)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #644345 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Attachment #644214 -
Attachment is obsolete: true
Attachment #644214 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Attachment #644345 -
Flags: review?(peterv) → review?(khuey)
Why are the tests commented out?
Assignee | ||
Comment 5•12 years ago
|
||
Because union codegen dumps all the unions in a single header file and that file is included from all bindings that use unions. So if I uncomment that, the header file ends up with TestInterface* and whatnot in it and real (non-test) bindings that use unions can't find the test headers and fail to build. I can add a comment to that effect to the test webidl if desired.
Comment on attachment 644345 [details] [diff] [review] Make sure to examine constructor signatures when looking for union types. Review of attachment 644345 [details] [diff] [review]: ----------------------------------------------------------------- Ok.
Attachment #644345 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/3a7ac28c4ca9
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla17
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a7ac28c4ca9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•