Closed Bug 775844 Opened 12 years ago Closed 12 years ago

Need to include constructor signature types when we make up our lists of types to examine

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Otherwise, for example, using a union type in a constructor argument doesn't actually pick it up as a type to generate union stuff for.
Also includes some distinguishability fixes
Attachment #644173 - Flags: review?(peterv)
Whiteboard: [need review]
Attachment #644173 - Attachment is obsolete: true
Attachment #644173 - Flags: review?(peterv)
Attachment #644214 - Attachment is obsolete: true
Attachment #644214 - Flags: review?(peterv)
Blocks: 777066
Attachment #644345 - Flags: review?(peterv) → review?(khuey)
Why are the tests commented out?
Because union codegen dumps all the unions in a single header file and that file is included from all bindings that use unions.  So if I uncomment that, the header file ends up with TestInterface* and whatnot in it and real (non-test) bindings that use unions can't find the test headers and fail to build.

I can add a comment to that effect to the test webidl if desired.
Comment on attachment 644345 [details] [diff] [review]
Make sure to examine constructor signatures when looking for union types.

Review of attachment 644345 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.
Attachment #644345 - Flags: review?(khuey) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/3a7ac28c4ca9
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/3a7ac28c4ca9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: