Closed
Bug 776271
Opened 12 years ago
Closed 12 years ago
Don't focus the content area when closing a places context menu
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
944 bytes,
patch
|
asaf
:
review+
mak
:
feedback+
|
Details | Diff | Splinter Review |
This was added in bug 365171. Whereas this.focus() in buildContextMenu is gone by now, this seems to be a leftover. As far as I can tell, no special treatment is needed. Focus should just go back to where it was.
Attachment #644667 -
Flags: review?(mak77)
Comment 1•12 years ago
|
||
Comment on attachment 644667 [details] [diff] [review] patch Review of attachment 644667 [details] [diff] [review]: ----------------------------------------------------------------- I think this was here to update places commands on focus, though looks like it's no more needed and I think it's fine to remove it. But since Mano originally added it, he may have some insight on the reasons.
Attachment #644667 -
Flags: review?(mano)
Attachment #644667 -
Flags: review?(mak77)
Attachment #644667 -
Flags: feedback+
Comment 2•12 years ago
|
||
Comment on attachment 644667 [details] [diff] [review] patch Indeed.
Attachment #644667 -
Flags: review?(mano) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/fadf5073473d
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fadf5073473d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in
before you can comment on or make changes to this bug.
Description
•