Closed Bug 776283 Opened 12 years ago Closed 12 years ago

function.toString() is missing trailing }

Categories

(Core :: JavaScript Engine, defect)

17 Branch
x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17
Tracking Status
firefox17 --- fixed

People

(Reporter: alice0775, Assigned: Benjamin)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/446b788ab99d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120721041038

For ex. evaluate the following code in Scratchpad(need chrome right)
alert( getBrowserSelection.toString() )
Then there is missing trailing }

Step To Reproduced
1. Open Firefox with Clean profile
2. Set devtools.chrome.enabled = true in about:config
3. Open Scratchpad (Shift+F4) and Environment > Browser checked
4. Run alert( getBrowserSelection.toString() )

Actual Results
  missing trailing }
 
Expected Resuls
  Should not

Regression window:
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e09c52e2c73
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720111908
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f9b341d6babd
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720112708
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e09c52e2c73&tochange=f9b341d6babd


Regressed by Bug 761723
The source needs to be decoded with nsScriptLoader::ConvertToUTF16 before being passed to the JS engine.
Attached patch decode the source properly (obsolete) — Splinter Review
Assignee: general → bpeterson
Attachment #644698 - Attachment is obsolete: true
Attachment #644759 - Flags: review?(bzbarsky)
Comment on attachment 644759 [details] [diff] [review]
decode source properly

r=me
Attachment #644759 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/1485b7d63b61
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
no need to track for 17, it's fixed. adjusting flags accordingly.
I verified on Windows 7 X86, Ubuntu X32 and Mac 10.8 and it is not reproducing on Firefox 17.0b5.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: