Closed
Bug 776316
Opened 12 years ago
Closed 12 years ago
Update Mozmill's httpd.js to use network.http.max-persistent-connections-per-server
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(3 files, 2 obsolete files)
989 bytes,
patch
|
Details | Diff | Splinter Review | |
97.41 KB,
patch
|
Details | Diff | Splinter Review | |
5.16 KB,
patch
|
rain1
:
review+
|
Details | Diff | Splinter Review |
Bug 770331 changed a pref on us, and our Mozmill tests have been busted ever since. We need to update the pref in our version of Mozmill to fix it. Not sure if the Mozmill guys know about this one, so I'm Cc'ing Henrik.
Assignee | ||
Comment 1•12 years ago
|
||
This makes the Mozmill tests pass again for me locally. I'll push to try just to make sure though.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
Has the upstream httpd component gotten an update? If yes Mozmill should be updated to use the latest version of httpd.js.
Comment 3•12 years ago
|
||
See bug 776453 which is now covering the mozmill core modules. I will have an updated version of Mozmill ready by today.
Assignee | ||
Comment 4•12 years ago
|
||
Landed with r=bustage-fix in comm-central as https://hg.mozilla.org/comm-central/rev/e76231334aff
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Assignee | ||
Comment 5•12 years ago
|
||
Whoops - so, I made a few mistakes here: 1) I assumed we maintained a fork of Mozmill 1.5. This is not true, and we shouldn't be monkey patching our instance of it. 2) The Mozmill team is working on fixing this upstream for both 1.5 and 2.0. See bug 776453. When the fix for 1.5 lands, we should update our instance of Mozmill. So I'm going to keep an eye on Bug 776453. When the 1.5 fix lands, I'll be backing out https://hg.mozilla.org/comm-central/rev/e76231334aff, and landing the update (after testing on Try of course). Thanks to Sid for setting me straight on that one. :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•12 years ago
|
||
Patch to back out the original fix.
Attachment #644720 -
Attachment is obsolete: true
Assignee | ||
Comment 7•12 years ago
|
||
Bring in Mozmill 1.5.latest
Assignee | ||
Updated•12 years ago
|
Attachment #645289 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Here's the update to 1.5.16
Assignee | ||
Comment 9•12 years ago
|
||
The 1.5.16 update changes how we get access to the fake HttpServer. This patch brings us in line with those changes. The try server build with all three of these patches can be found here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f5f2bd8402cf (The XPCShell failures are a known toolkit bug being actively worked on)
Attachment #645300 -
Flags: review?(sagarwal)
Updated•12 years ago
|
Attachment #645300 -
Flags: review?(sagarwal) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Backed out original patch from comm-central: https://hg.mozilla.org/comm-central/rev/927b4c1ae376 Landed Mozmill update: https://hg.mozilla.org/comm-central/rev/16bca5fa8f08 and test fixups: https://hg.mozilla.org/comm-central/rev/c2c87f2fd534 Thanks Sid!
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•